fix!: resolve residual issues with removing prometheus port #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
breaking-change
waynexia
approved these changes
Aug 22, 2023
Codecov Report
@@ Coverage Diff @@
## develop #2227 +/- ##
===========================================
- Coverage 84.53% 84.22% -0.31%
===========================================
Files 701 701
Lines 113262 113799 +537
===========================================
+ Hits 95748 95850 +102
- Misses 17514 17949 +435 |
yuanbohan
approved these changes
Aug 22, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
…Team#2227) * fix: resolve residual issues when removing prometheus port * fix: remove prometheus from sample config as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This patch resolves residual issues with #2005 attempt to merge prometheus apis into default http port. Fixes includes:
/api/v1/to prometheus query path for compatibilityprom_addrand options structs completelyChecklist
Refer to a related PR or issue link (optional)